[CALCITE-6968] SqlUpdate#getOperandList omits sourceSelect operand#4857
Open
macroguo-ghy wants to merge 1 commit intoapache:mainfrom
Open
[CALCITE-6968] SqlUpdate#getOperandList omits sourceSelect operand#4857macroguo-ghy wants to merge 1 commit intoapache:mainfrom
macroguo-ghy wants to merge 1 commit intoapache:mainfrom
Conversation
macroguo-ghy
force-pushed
the
calcite-6968
branch
from
8c7d92f to
cc46704
Compare
caicancai
reviewed
Apr 3, 2026
| operands[3], | ||
| null, | ||
| (SqlIdentifier) operands[4]); | ||
| (SqlSelect) operands[4], |
Member
There was a problem hiding this comment.
Are there any cases where it cannot be converted to SQLSelect?
Contributor
Author
There was a problem hiding this comment.
According to the SqlOperator's definition, its operands must be consistent with SqlCall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-6968
Changes Proposed
SqlUpdateso its operand contract consistently includes the internalsourceSelectacrossgetOperandList(),setOperand(), andOPERATOR.createCall(...).unparse()behavior so the internalsourceSelectremains internal.