[CALCITE-7420] Convert RelOptRulesTest to Quidem scripts#4812
Closed
xiedeyantu wants to merge 1 commit intoapache:mainfrom
Closed
[CALCITE-7420] Convert RelOptRulesTest to Quidem scripts#4812xiedeyantu wants to merge 1 commit intoapache:mainfrom
xiedeyantu wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
Since Julian has already started this task, I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CALCITE-7420
This PR represents the first step.
Implementing the relevant control commands. The new command is named
!rule-plan. We avoided the!plan-xxxnaming convention because Quidem's built-in command parser treats any command starting with "plan" as a reserved keyword.An empty rule set is denoted by an empty string
""rather thanNONE. This design choice eliminates the need for special-case handling ofNONEin the code and avoids the overhead of filtering it out during reflective rule instance generation.