[CALCITE-7424] In Lint, support sort specifications#4811
Closed
xiedeyantu wants to merge 1 commit intoapache:mainfrom
Closed
[CALCITE-7424] In Lint, support sort specifications#4811xiedeyantu wants to merge 1 commit intoapache:mainfrom
xiedeyantu wants to merge 1 commit intoapache:mainfrom
Conversation
|
Contributor
|
Can we merge #4813 rather than this PR. I logged this case because I was intending to fix it. (Which is a best practice, anyway.) And less than a day later I created a PR. |
Member
Author
Of course! I submitted this PR because I frequently keep an eye on unresolved JIRA issues. I believe your implementation will be better, so I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CALCITE-7424