Skip to content

Port ReadSpannerSchemaTest off deprecated DoFnTester #40921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Supersaiyan101 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Port ReadSpannerSchemaTest off deprecated DoFnTester #40921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c653315
Port ReadSpannerSchemaTest off deprecated DoFnTester
Supersaiyan101 Oct 31, 2026
2236517
Address review feedback: import Lists from vendored Guava
Supersaiyan101 Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 54 additions & 38 deletions ...loud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/ReadSpannerSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,14 @@
import com.google.cloud.spanner.Type;
import java.util.Arrays;
import java.util.List;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
import org.apache.beam.sdk.transforms.Create;
import org.apache.beam.sdk.transforms.DoFnTester;
import org.apache.beam.sdk.transforms.ParDo;
import org.apache.beam.sdk.transforms.View;
import org.apache.beam.sdk.transforms.windowing.GlobalWindow;
import org.apache.beam.sdk.values.PCollection;
import org.apache.beam.sdk.values.PCollectionView;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.Lists;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
Expand Down Expand Up @@ -148,25 +150,33 @@ public void simple() throws Exception {
.withServiceFactory(serviceFactory);

PCollectionView<Dialect> dialectView =
pipeline.apply(Create.of(Dialect.GOOGLE_STANDARD_SQL)).apply(View.asSingleton());
pipeline.run();
DoFnTester<Void, SpannerSchema> tester =
DoFnTester.of(new ReadSpannerSchema(config, dialectView));
tester.setSideInput(dialectView, GlobalWindow.INSTANCE, Dialect.GOOGLE_STANDARD_SQL);

List<SpannerSchema> schemas = tester.processBundle(Arrays.asList((Void) null));

assertEquals(1, schemas.size());

SpannerSchema schema = schemas.get(0);
pipeline
.apply("CreateDialect", Create.of(Dialect.GOOGLE_STANDARD_SQL))
.apply(View.asSingleton());
PCollection<SpannerSchema> schemas =
pipeline
.apply("CreateVoid", Create.of((Void) null))
.apply(
ParDo.of(new ReadSpannerSchema(config, dialectView)).withSideInputs(dialectView));

PAssert.that(schemas)
.satisfies(
iterable -> {
List<SpannerSchema> schemaList = Lists.newArrayList(iterable);
assertEquals(1, schemaList.size());

SpannerSchema schema = schemaList.get(0);
assertEquals(1, schema.getTables().size());

SpannerSchema.Column column = SpannerSchema.Column.create("key", Type.int64());
SpannerSchema.KeyPart keyPart = SpannerSchema.KeyPart.create("key", false);

assertThat(schema.getColumns("test"), contains(column));
assertThat(schema.getKeyParts("test"), contains(keyPart));
return null;
});

assertEquals(1, schema.getTables().size());

SpannerSchema.Column column = SpannerSchema.Column.create("key", Type.int64());
SpannerSchema.KeyPart keyPart = SpannerSchema.KeyPart.create("key", false);

assertThat(schema.getColumns("test"), contains(column));
assertThat(schema.getKeyParts("test"), contains(keyPart));
pipeline.run();
}

@Test
Expand All @@ -186,24 +196,30 @@ public void pgSimple() throws Exception {
.withServiceFactory(serviceFactory);

PCollectionView<Dialect> dialectView =
pipeline.apply(Create.of(Dialect.POSTGRESQL)).apply(View.asSingleton());
pipeline.run();
DoFnTester<Void, SpannerSchema> tester =
DoFnTester.of(new ReadSpannerSchema(config, dialectView));
tester.setSideInput(dialectView, GlobalWindow.INSTANCE, Dialect.POSTGRESQL);

List<SpannerSchema> schemas = tester.processBundle(Arrays.asList((Void) null));

assertEquals(1, schemas.size());

SpannerSchema schema = schemas.get(0);
pipeline.apply("CreateDialect", Create.of(Dialect.POSTGRESQL)).apply(View.asSingleton());
PCollection<SpannerSchema> schemas =
pipeline
.apply("CreateVoid", Create.of((Void) null))
.apply(
ParDo.of(new ReadSpannerSchema(config, dialectView)).withSideInputs(dialectView));

PAssert.that(schemas)
.satisfies(
iterable -> {
List<SpannerSchema> schemaList = Lists.newArrayList(iterable);
assertEquals(1, schemaList.size());

SpannerSchema schema = schemaList.get(0);
assertEquals(1, schema.getTables().size());

SpannerSchema.Column column = SpannerSchema.Column.create("key", Type.int64());
SpannerSchema.KeyPart keyPart = SpannerSchema.KeyPart.create("key", false);

assertThat(schema.getColumns("test"), contains(column));
assertThat(schema.getKeyParts("test"), contains(keyPart));
return null;
});

assertEquals(1, schema.getTables().size());

SpannerSchema.Column column = SpannerSchema.Column.create("key", Type.int64());
SpannerSchema.KeyPart keyPart = SpannerSchema.KeyPart.create("key", false);

assertThat(schema.getColumns("test"), contains(column));
assertThat(schema.getKeyParts("test"), contains(keyPart));
pipeline.run();
}
}
Loading