add Spark job-server --add-opens#39339
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39339 +/- ##
============================================
- Coverage 54.76% 54.76% -0.01%
Complexity 1716 1716
============================================
Files 1066 1066
Lines 169075 169080 +5
Branches 1255 1255
============================================
+ Hits 92589 92590 +1
- Misses 74269 74273 +4
Partials 2217 2217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues when running Spark job servers on newer Java versions by explicitly adding required '--add-opens' flags. These changes ensure that the Spark runner correctly configures the JVM environment, preventing potential access errors. Additionally, the PR includes updates to test triggers to verify these changes across the relevant CI pipelines. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds JVM --add-opens arguments to the Spark job server startup commands in both Go and Python SDKs to support newer Java versions. It also rearranges the Python job server subprocess command to place JVM properties before the -jar argument. The review feedback correctly identifies potential TypeError exceptions if self._jvm_properties is None when calling list() in both job_server.py and spark_runner.py, providing robust code suggestions to handle this case safely.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| subprocess_cmd = [self._java_launcher] + list(self._jvm_properties) + [ | ||
| '-jar', jar_path |
There was a problem hiding this comment.
If self._jvm_properties is None, calling list(self._jvm_properties) will raise a TypeError. Using self._jvm_properties or [] provides a safe fallback to prevent potential runtime errors.
| subprocess_cmd = [self._java_launcher] + list(self._jvm_properties) + [ | |
| '-jar', jar_path | |
| subprocess_cmd = [self._java_launcher] + list(self._jvm_properties or []) + [ | |
| '-jar', jar_path |
| self._jvm_properties = list(self._jvm_properties) | ||
| for arg in SPARK_JAR_JOB_SERVER_JVM_ARGS: | ||
| if arg not in self._jvm_properties: | ||
| self._jvm_properties.append(arg) |
There was a problem hiding this comment.
If self._jvm_properties is None, calling list(self._jvm_properties) will raise a TypeError. Using self._jvm_properties or [] ensures the code is robust against None values.
| self._jvm_properties = list(self._jvm_properties) | |
| for arg in SPARK_JAR_JOB_SERVER_JVM_ARGS: | |
| if arg not in self._jvm_properties: | |
| self._jvm_properties.append(arg) | |
| self._jvm_properties = list(self._jvm_properties or []) | |
| for arg in SPARK_JAR_JOB_SERVER_JVM_ARGS: | |
| if arg not in self._jvm_properties: | |
| self._jvm_properties.append(arg) |
|
cc: @Abacn |
2 participants
Fixes: #31475 , #30645, #33765
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.