Add Dynamic Schema support to StorageWriteToBigQuery#39236
Add Dynamic Schema support to StorageWriteToBigQuery#39236jrmccluskey wants to merge 15 commits into
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds support for dynamic schemas and schema side inputs when writing to BigQuery using the Storage Write API (StorageWriteToBigQuery). It includes updates to handle callable schemas, passes schema side inputs through the pipeline, adds validation to ensure dynamic schemas are only used with dynamic destinations, and provides comprehensive unit and integration tests. There are no review comments, and the implementation looks solid, so I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request introduces support for dynamic schemas when writing to dynamic destinations using the BigQuery Storage Write API, including a new dynamic_schema helper function, updates to StorageWriteToBigQuery to handle dynamic schemas and side inputs, and comprehensive unit tests. The reviewer feedback highlights critical issues that need to be addressed: potential runtime NameError exceptions from referencing the bigquery module namespace within bigquery.py, unintended in-place mutation of user-provided schemas during merging, and potential serialization/encoding errors (CoderException) alongside performance overhead caused by dynamic beam.Row instantiation with None values.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Implements support for using dynamic schemas in StorageWriteToBigQuery invocations.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.