[Experimental] Fix Yaml Xlang Test Timeout#38798
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses persistent timeouts in the Yaml Xlang test suite by optimizing the dependency installation workflow. By migrating to uv for package management, the build process is streamlined, and adjustments to dependency handling help mitigate issues related to outdated package options. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Beam Gradle plugin to use uv for installing Python packages, consolidating the installation targets into a single command. The review feedback suggests retaining the --retries 10 option for both pip install uv and uv pip install to prevent flaky CI failures due to transient network issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| executable 'sh' | ||
| args '-c', ". ${project.ext.envdir}/bin/activate && pip install --pre --retries 10 ${distTarBall}[${extra}]" | ||
| } | ||
| args '-c', ". ${project.ext.envdir}/bin/activate && pip install uv && uv pip install --pre ${installTargets}" |
There was a problem hiding this comment.
To prevent flaky CI failures due to transient network issues, it is highly recommended to retain the --retries 10 option for both the pip install uv command and the subsequent uv pip install command. uv supports the --retries option just like pip does.
args '-c', ". ${project.ext.envdir}/bin/activate && pip install --retries 10 uv && uv pip install --retries 10 --pre ${installTargets}"
There was a problem hiding this comment.
uv automatically does 3 retries; however it does not support the retries flag at present.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Swap dependency resolution to uv, move ml dependencies to p310_ml_test to avoid out-of-date options.
Test run on branch: https://github.com/apache/beam/actions/runs/26908385277/job/79379464502
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.