Skip to content

[OpenTelemetry] Default open telemetry configuration behind experiment#38784

Open
stankiewicz wants to merge 1 commit into
apache:masterfrom
stankiewicz:otel_default_config_job_submission
Open

[OpenTelemetry] Default open telemetry configuration behind experiment#38784
stankiewicz wants to merge 1 commit into
apache:masterfrom
stankiewicz:otel_default_config_job_submission

Conversation

@stankiewicz
Copy link
Copy Markdown
Contributor

Add default open telemetry tracing configuration for dataflow runners.
no-op - change is behind experiment.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces default OpenTelemetry tracing properties for Dataflow runners. By injecting standard OTLP exporter settings and service metadata into the pipeline options, it enables easier observability integration for users who opt-in via the experimental flag.

Highlights

  • OpenTelemetry Configuration: Added default OpenTelemetry tracing configuration for Dataflow runners, encapsulated behind an experimental flag.
  • Feature Flagging: The new configuration is gated by the 'enable_opentelemetry_tracing' experiment, ensuring no impact on existing production workloads.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for configuring OpenTelemetry tracing in the DataflowRunner when the 'enable_opentelemetry_tracing' experiment is enabled. It retrieves and updates the OpenTelemetry properties on SdkHarnessOptions. A review comment correctly identifies a potential issue where the retrieved properties map might be immutable, which would lead to an UnsupportedOperationException when modified. The reviewer suggested copying the existing properties into a new mutable HashMap to avoid this error.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@stankiewicz stankiewicz force-pushed the otel_default_config_job_submission branch from 0017284 to 88441ba Compare June 3, 2026 12:59
@stankiewicz stankiewicz force-pushed the otel_default_config_job_submission branch from 88441ba to ca7b3ad Compare June 3, 2026 13:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Assigning reviewers:

R: @tvalentyn added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants