AVRO-4240: [Java] Size DataFileWriter output buffer to fit entire block frame#3705
Open
belugabehr wants to merge 1 commit intoapache:mainfrom
Open
AVRO-4240: [Java] Size DataFileWriter output buffer to fit entire block frame#3705belugabehr wants to merge 1 commit intoapache:mainfrom
belugabehr wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull improves write performance as DataFileWriter wraps its output in a BufferedFileOutputStream that uses the default 8KB BufferedOutputStream buffer. The default sync interval was increased from 16KB to 64KB in AVRO-1398 but the output buffer was never adjusted. Since block data far exceeds 8KB, each block write results in multiple write syscalls and flushes instead of one.
This change sizes the output buffer to fit a complete block frame (compressed data + varint headers + sync marker) so that all writes accumulate and flush in a single syscall, fixing AVRO-4240.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation