AVRO-4202: Refer to fields for generated hashCode #3547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated hashCode function has a local parameter called result. To prevent this local variable to conflict with field which have the same name, it has to refer to the fields with `this.<fieldName>` making it unambiguous refer to fields and not local variables.
4 tasks
martin-g
approved these changes
Nov 14, 2025
RyanSkraba
approved these changes
Nov 14, 2025
RyanSkraba
changed the title
RyanSkraba
pushed a commit
that referenced
this pull request
Nov 14, 2025
The generated hashCode function has a local parameter called result. To prevent this local variable to conflict with field which have the same name, it has to refer to the fields with `this.<fieldName>` making it unambiguous refer to fields and not local variables.
Contributor
|
Thanks so much for this fix! It should be included in the next minor release. Let me know if you want me to assign you this JIRA! I've marked it as Resolved, but I didn't find an account for you. |
Contributor
Author
|
@RyanSkraba thanks a lot for cherry picking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated hashCode function has a local parameter called result. To prevent this local variable to conflict with field which have the same name, it has to refer to the fields with
this.<fieldName>making it unambiguous refer to fields and not local variables.What is the purpose of the change
Fix a name collision in the generated
hashCodefunction reported in AVRO-4202Verifying this change
This change is a trivial rework I also manually verified. Let me know if you want an extra test.
Documentation