[AURON #2323] Refactor and rename cast test suites for ANSI mode on and off#2324
Open
cxzl25 wants to merge 1 commit into
Open
[AURON #2323] Refactor and rename cast test suites for ANSI mode on and off#2324cxzl25 wants to merge 1 commit into
cxzl25 wants to merge 1 commit into
Conversation
weiqingy
reviewed
Jun 11, 2026
weiqingy
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this on — the rename correctly tracks Spark 4's base-class refactor: extending CastWithAnsiOnSuite/CastWithAnsiOffSuite and dropping the AuronAnsiCast*WithAnsiMode* wrappers (Spark 4 folded the standalone AnsiCast path into Cast, so those base classes no longer exist) is the right mapping, and CI confirms both modules now compile past #2323. One question on the overall check state.
- The spark-4.0 and spark-4.1 checks are still red on the latest run, but they now fail in the scalatest phase rather than at compile — so the rename did its job: both modules reach
scala-test-compileand run the suites. The remaining failures are in other suites in theauron-spark-tests-spark40/41modules that only surface now that the module compiles —AuronTryCastSuiteand the parquet/JSON read suites hitTASK_WRITE_FAILEDandRemoteClassLoaderError: org.apache.spark.sql.catalyst.expressions.Object, alongside native panics likemap_from_arrays does not support null map keys. The two renamed cast suites themselves run with every case reported!!! IGNORED !!!, so they aren't the cause. Is the intent here to unblock compilation while those Spark 4 runtime failures are tracked separately? If so, would it be worth a line in the description noting spark-4.0/4.1 will stay red pending those follow-ups, so it's clear the check isn't expected to go green with this merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2323
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?
GHA