-
Notifications
You must be signed in to change notification settings - Fork 224
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guixiaowen
wants to merge
10
commits into
apache:master
Choose a base branch
from
guixiaowen:add_hudi_convert
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−15
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
173dbec
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan…
883de9d
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan…
881897f
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan…
b443a21
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan…
34624f5
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan…
5e4adcc
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan
4fbb6ed
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan
ab84134
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan
f34ea83
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan
ab1264d
[AURON #2252] Add support for auron.never.convert.reason in Hudi scan
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The asserts in
isEnabledchange the contract of this method: it's supposed to returnfalsewhen not enabled (sofindcan skip it), but now it throws instead. The exception is caught upstream inAuronConverters, so it works — but it's fragile: if bothisEnabledandisSupportedthrow, only the first reason is ever recorded. Also, the finalSparkAuronConfiguration.ENABLE_HUDI_SCAN.get() && supportedis now dead code — it can never be reached.Consider keeping
isEnabled/isSupportedas pure predicates (returnfalse) and recording the reason only inconvert, where the context is clearer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yew1eb ye Thank you very much for the code review.
Regarding isEnabled and isSupported – they are called within AuronConverters. If isEnabled returns false, isSupported should not be called at all, so I believe both methods will not throw exceptions at the same time. The reasons for not being converted are different between isEnabled and isSupported, and those reasons are only known within these methods, which is why I added the assertions there.
May I ask if your suggestion is to keep isEnabled and isSupported as pure predicates that simply return true or false – without handling too many scenarios inside them – and move the logic for checking Spark version and Hudi format type into the convert method instead?
Is my understanding correct? If so, I will make the changes accordingly. I would really appreciate your confirmation.
Thank you again for your guidance!