refactor(condvar): simplify waiter state and notification handoff - #348
Merged
Merged
Conversation
Store WaitState directly in the wait list. Use the returned or removed state instead of mutating auxiliary variables from unlink predicates, following the existing notify_all path. Keep registration before mutex release and waker destruction and wake callbacks outside the waiter lock. Extend the existing cancellation tests to cover both before repolling a selected waiter and while reacquiring its mutex, with and without a successor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store
WaitStatedirectly in the condition variable's wait list, removing the single-fieldWaitNodewrapper. Read the returned or removed state to extract a waker and decide notification handoff, following the existingnotify_allpath instead of mutating auxiliary variables from unlink predicates. Waker destruction and wake callbacks remain outside the waiter lock.Extend the existing
notify_onecancellation tests to cover cancellation before repolling a selected waiter as well as while reacquiring its mutex, both with and without a successor. Public behavior is unchanged.Validation:
cargo x test(618 passed),cargo x check(26 feature configurations), andcargo x lint.