Repository navigation
refactor: replace waker batch iteration with wake_all - #344
Merged
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace repeated batch iteration with
WakerBatch::wake_all(&mut self)and remove itsIteratorimplementation. Waking the whole batch allows a single inline length and aVecoverflow buffer, while preserving FIFO order and reusing storage between semaphore notification rounds. All callers continue to invoke wake callbacks after unlocking.Update tests to cover the spill boundary, repeated refill/wake cycles, and destruction of unwoken entries.
Validation:
cargo x test(616 tests),cargo x check(26 feature configurations),cargo x lint, and focused WakerBatch Miri checks with the CI flags across four seeds.