Repository navigation
Conversation
The legacy-prefix compatibility fallback could auto-create a queue or topic under its old prefixed name when a broad catch-all address match allowed auto-create, even if the specific match for the real address explicitly disabled it, silently bypassing the intended configuration. Changes this commit includes: - Restrict the legacy-prefix fallback to using an already-existing resource only. Never auto-create under the old prefix. - Apply the same fix to topics. - Remove a temporary-destination lookup performed during ordinary (non-temporary) queue/topic resolution; it served no legitimate purpose there and could resolve to the wrong destination in rare configurations. - Add a parameterized test covering queue and topic behavior across the affected scenarios. - Refactored & simplified related methods Co-Authored-By: Justin Bertram <jbertram@apache.org>
Contributor
Author
|
The full test-suite is good on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy-prefix compatibility fallback could auto-create a queue or topic under its old prefixed name when a broad catch-all address match allowed auto-create, even if the specific match for the real address explicitly disabled it, silently bypassing the intended configuration.
Changes this commit includes: