ARTEMIS-5889 Support reload of connection router config#6240
Open
tabish121 wants to merge 1 commit intoapache:mainfrom
Open
ARTEMIS-5889 Support reload of connection router config#6240tabish121 wants to merge 1 commit intoapache:mainfrom
tabish121 wants to merge 1 commit intoapache:mainfrom
Conversation
gtully
approved these changes
Feb 18, 2026
Contributor
gtully
left a comment
gtully
left a comment
There was a problem hiding this comment.
looks good. I think only a comment is out of place which reflects the acceptor reload logic.
...r/src/main/java/org/apache/activemq/artemis/core/server/routing/ConnectionRouterManager.java
Outdated
Show resolved
Hide resolved
tabish121
force-pushed
the
connection-router-config-reload
branch
from
8557355 to
c4d9738
Compare
Contributor
|
and a little rebase is necessary, I was making use of the limited reload that was present through the sharing of config objects, but that will no be done correctly. |
tabish121
force-pushed
the
connection-router-config-reload
branch
2 times, most recently
from
6870bc0 to
a008c15
Compare
tabish121
force-pushed
the
connection-router-config-reload
branch
from
a008c15 to
3849715
Compare
Contributor
Author
|
I've rebased on top of the latest changes on main and retested in CI |
brusdev
reviewed
Feb 19, 2026
Member
brusdev
left a comment
brusdev
left a comment
There was a problem hiding this comment.
Looking good! Do you think we could add a few more test cases to cover the cache and the pool configs?
...c/test/java/org/apache/activemq/artemis/core/server/routing/ConnectionRouterManagerTest.java
Show resolved
Hide resolved
tabish121
force-pushed
the
connection-router-config-reload
branch
from
3849715 to
f317b53
Compare
Support connection routers being added, updated or removed via configuration updates either XML or via broker properties.
tabish121
force-pushed
the
connection-router-config-reload
branch
from
f317b53 to
5a94068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support connection routers being added, updated or removed via configuration updates either XML or via broker properties.