Skip to content

GH-50239: [R] Data race issue from R API requests in parallel region #50488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisisnic wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

GH-50239: [R] Data race issue from R API requests in parallel region #50488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions r/src/RTasks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ Status RTasks::Finish() {
}
}

// then wait for the parallel tasks to finish
// submit the delayed parallel tasks and wait for them to finish
if (use_threads_) {
for (auto& task : delayed_parallel_tasks_) {
parallel_tasks_->Append(std::move(task));
}
status &= parallel_tasks_->Finish();
}

Expand All @@ -50,14 +53,15 @@ Status RTasks::Finish() {

void RTasks::Append(bool parallel, RTasks::Task&& task) {
if (parallel && use_threads_) {
parallel_tasks_->Append(std::move(task));
delayed_parallel_tasks_.push_back(std::move(task));
} else {
delayed_serial_tasks_.push_back(std::move(task));
}
}

void RTasks::Reset() {
delayed_serial_tasks_.clear();
delayed_parallel_tasks_.clear();

stop_source_.Reset();
if (use_threads_) {
Expand Down
1 change: 1 addition & 0 deletions r/src/r_task_group.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ class RTasks {
StopSource stop_source_;
std::shared_ptr<arrow::internal::TaskGroup> parallel_tasks_;
std::vector<Task> delayed_serial_tasks_;
std::vector<Task> delayed_parallel_tasks_;
};

} // namespace r
Expand Down
Loading