Skip to content

GH-46178: [R] source_node alignment warning #50120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisnic merged 1 commit into from
Jun 8, 2026
+4 −2
Merged

GH-46178: [R] source_node alignment warning #50120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions r/src/compute-exec.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ std::shared_ptr<acero::ExecPlan> ExecPlan_create(bool use_threads) {
// TODO(weston) using gc_context() in this way is deprecated. Once ordering has
// been added we can probably entirely remove all reference to ExecPlan from R
// in favor of DeclarationToXyz
auto plan =
ValueOrStop(acero::ExecPlan::Make(use_threads ? &threaded_context : gc_context()));
acero::QueryOptions query_options;
query_options.unaligned_buffer_handling = acero::UnalignedBufferHandling::kReallocate;
auto plan = ValueOrStop(acero::ExecPlan::Make(
std::move(query_options), use_threads ? &threaded_context : gc_context()));
Comment on lines +51 to +54
Copy link
Copy Markdown
Member Author

@thisisnic thisisnic Jun 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this is pedantic, most of our users don't engage with this at this level. The real question isn't whether we should document it but whether there'll likely be user impact. Given we don't see these warnings particularly often on our tests, I'm going to assume minimal impact.


return plan;
}
Expand Down
Loading