Skip to content

GH-33420: [R] Improve error message when providing a mix of readr and Arrow options #50048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rich-T-kid wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

GH-33420: [R] Improve error message when providing a mix of readr and Arrow options #50048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfcfb6e
resolves #33420
Rich-T-kid May 27, 2026
c36dfb0
revised PR comments
Rich-T-kid May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion r/R/dataset-format.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,11 @@ csv_file_format_parse_opts <- function(...) {
# Catch cases when the user specifies a mix of Arrow C++ options and
# readr-style options
if (!all(is_readr_opt)) {
stop("Use either Arrow parse options or readr parse options, not both", call. = FALSE)
abort(c(
"CSV parse options must be either Arrow-style or readr-style, not both.",
i = sprintf("Arrow options used: %s.", oxford_paste(opt_names[is_arrow_opt])),
i = sprintf("readr options used: %s.", oxford_paste(opt_names[is_readr_opt]))
))
}
do.call(readr_to_csv_parse_options, opts) # all options have readr-style names
} else {
Expand Down
6 changes: 4 additions & 2 deletions r/tests/testthat/test-dataset-csv.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,16 +231,18 @@ test_that("readr parse options", {
)

# With both Arrow and readr parse options (disallowed)
expect_error(
err <- expect_error(
open_dataset(
tsv_dir,
partitioning = "part",
format = "text",
quote = "\"",
quoting = TRUE
),
"either"
"Arrow-style or readr-style"
)
expect_match(conditionMessage(err), "Arrow options used:.*quoting")
expect_match(conditionMessage(err), "readr options used:.*quote")

# With ambiguous partial option names (disallowed)
expect_error(
Expand Down
Loading