Skip to content

GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues #49223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonkeane wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

GH-49287: [C++][R] Clean up any other C++20 partial compatibility issues #49223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cpp/src/arrow/sparse_tensor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,9 +406,19 @@ std::string SparseCSFIndex::ToString() const { return std::string("SparseCSFInde

bool SparseCSFIndex::Equals(const SparseCSFIndex& other) const {
auto eq = [](const auto& a, const auto& b) { return a->Equals(*b); };
// TODO: remove the use of std::equal when we no longer have partial C++20 support with
// CRAN.
#if defined(__cpp_lib_ranges) && __cpp_lib_ranges >= 201911L
return axis_order() == other.axis_order() &&
std::ranges::equal(indices(), other.indices(), eq) &&
std::ranges::equal(indptr(), other.indptr(), eq);
#else
return axis_order() == other.axis_order() &&
std::equal(indices().begin(), indices().end(), other.indices().begin(),
other.indices().end(), eq) &&
std::equal(indptr().begin(), indptr().end(), other.indptr().begin(),
other.indptr().end(), eq);
#endif
}

// ----------------------------------------------------------------------
Expand Down
Loading