fix(ipc): Avoid panic on malformed compressed buffer prefix#9802
Open
pchintar wants to merge 1 commit intoapache:mainfrom
Open
fix(ipc): Avoid panic on malformed compressed buffer prefix#9802pchintar wants to merge 1 commit intoapache:mainfrom
pchintar wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The IPC format specifies that compressed buffers are encoded as:
The current implementation assumes this invariant when reading the prefix during decompression.
However, in the reader path, buffers are constructed from metadata (
offset,length) and passed to the decompression logic without validating that they contain at least the required 8-byte prefix.In contrast, Parquet defensively validates input before reading fixed-size prefixes, e.g.:
This ensures malformed or truncated input does not cause panics.
In IPC, however, the prefix is read without a prior length check, so malformed/truncated input (buffer < 8 bytes) can lead to a panic instead of returning an error.
What changes are included in this PR?
read_uncompressed_sizeto ensurebuffer.len() >= 8ArrowError::IpcErrorwhen the prefix is missingdecompress_to_bufferAre these changes tested?
Yes.
Added
test_read_uncompressed_size_rejects_short_prefixExisting compression tests remain unchanged and pass
Are there any user-facing changes?
No.