Draft
Conversation
In the non-terminal skip path, miniblocks with bit_width=0 no longer call get_batch. Every delta in a bw=0 miniblock equals min_delta exactly, so last_value can be advanced by n * min_delta using a single wrapping_mul + wrapping_add. When min_delta == 0 no update is needed at all. Common in practice: timestamps with uniform step, run-length-like data. The bw=0 case is the hot path for those columns. Benchmarks vs upstream HEAD: bw=0 single-value skip: -21.6% bw=0 increasing-value skip: -24.3% Split from apache#9769 as requested by reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
58.2.0(April 2026) #9109Rationale for this change
Keep code flowing
What changes are included in this PR?
Are these changes tested?
By CI
Are there any user-facing changes?
New version / changelog