Deprecate parquet::basic::ColumnOrder::sort_order_for_type#10104
Draft
etseidl wants to merge 45 commits into
Draft
Deprecate parquet::basic::ColumnOrder::sort_order_for_type#10104etseidl wants to merge 45 commits into
parquet::basic::ColumnOrder::sort_order_for_type#10104etseidl wants to merge 45 commits into
Conversation
etseidl
added
api-change
Contributor
Author
|
Note: this PR contains all the changes from #9619, so this can't really be reviewed until that PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
sort_order_for_typepublic function #10103.Rationale for this change
With the addition of new
ColumnOrdervariants, the public functionsort_order_for_typehas become unwieldy.What changes are included in this PR?
Add a deprecation notice to
sort_order_for_type, and add a newpub(crate)functionget_sort_order_for_typeto replace it. The preferred path to obtain aSortOrderis now viaColumnOrder::sort_order.Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
Yes, this deprecates the public
sort_order_for_type.