fix(array): make SetNull idempotent and track null count#905
Open
fallintoplace wants to merge 1 commit into
Open
fix(array): make SetNull idempotent and track null count#905fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
builder.SetNullnull-count accounting and idempotency.Why this fix
SetNullcleared the validity bit but did not updateb.nulls, so bitmap andNullN()metadata could diverge. RepeatedSetNull(i)also inflated null count.Changes
NullNonly when the targeted entry is currently valid.MapBuilderdelegates the same semantics.Files
arrow/array/builder.goarrow/array/builder_test.goarrow/array/map_test.goValidation
NullN()after setting initial nullsSetNull(0)does not change countMapBuilder.NullN()reflects null transitions.Bug details