fix(arreflect): validate primitive conversion assignment overflow checks#903
Open
fallintoplace wants to merge 1 commit into
Open
fix(arreflect): validate primitive conversion assignment overflow checks#903fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent silent corruption in
arreflectprimitive conversions by validating numeric assignment bounds before setting through reflection.Why this fix
setPrimitiveValueusedSetInt/SetUint/SetFloatdirectly for Arrow numeric types. That allowed values outside the target Go type range to wrap/truncate, so bad data could pass through without errors until consumed by fast paths relying on value integrity.Changes
OverflowIntOverflowUintOverflowFloatErrTypeMismatch-wrapped errors on overflow.Files
arrow/array/arreflect/reflect_arrow_to_go.goarrow/array/arreflect/reflect_arrow_to_go_test.goValidation
int64->int8uint64->uint8float64->float32Bug details