feat(java/driver/jni): metadata methods, validation suite#3972
Merged
lidavidm merged 5 commits intoapache:mainfrom Feb 19, 2026
Merged
feat(java/driver/jni): metadata methods, validation suite#3972lidavidm merged 5 commits intoapache:mainfrom
lidavidm merged 5 commits intoapache:mainfrom
Conversation
lidavidm
reviewed
Feb 15, 2026
java/driver/jni/src/main/java/org/apache/arrow/adbc/driver/jni/JniConnection.java
Outdated
Show resolved
Hide resolved
java/driver/jni/src/main/java/org/apache/arrow/adbc/driver/jni/JniStatement.java
Show resolved
Hide resolved
lidavidm
reviewed
Feb 18, 2026
Member
lidavidm
left a comment
There was a problem hiding this comment.
Thanks! Just one more comment
Comment on lines
532
to
560
Member
There was a problem hiding this comment.
I think this is subject to the same problem as with ArrowArrayStream above: we need to immediately snapshot the contents of the ArrowSchema into a Java object instead of assuming that the allocation of make_unique here will actually persist.
Contributor
Author
There was a problem hiding this comment.
probably best to introduce new NativeSchemaResult class for this as well to mirror NativeQueryResult since there will be other methods that return schemas (ExecuteSchema). sounds good?
lidavidm
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exportBindmethod in JniStatement that exports bound data to c before each execution rather than during bind call.