Skip to content

feat(java/driver/jni): metadata methods, validation suite#3972

Merged
lidavidm merged 5 commits intoapache:mainfrom
tokoko:jni-get-objects
Feb 19, 2026
Merged

feat(java/driver/jni): metadata methods, validation suite#3972
lidavidm merged 5 commits intoapache:mainfrom
tokoko:jni-get-objects

Conversation

@tokoko
Copy link
Contributor

@tokoko tokoko commented Feb 14, 2026

  • adds bindings for: GetObjects, GetInfo, GetTableSchema, GetTableTypes
  • adds jni-validation-sqlite suite, most of the stuff in there is still disabled because of sqlite issues. I'll try later to add some of those to quirks and make it work.
  • fixes deferred bind bug that came up in validation suite. c driver expects user to rebind if data changes, while java seems to allow a caller to alter VectorSchemaRoot after it has been bound. Added exportBind method in JniStatement that exports bound data to c before each execution rather than during bind call.

@tokoko tokoko requested a review from lidavidm as a code owner February 14, 2026 06:09
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one more comment

Comment on lines 532 to 560
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is subject to the same problem as with ArrowArrayStream above: we need to immediately snapshot the contents of the ArrowSchema into a Java object instead of assuming that the allocation of make_unique here will actually persist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably best to introduce new NativeSchemaResult class for this as well to mirror NativeQueryResult since there will be other methods that return schemas (ExecuteSchema). sounds good?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@lidavidm lidavidm merged commit 7b38cf4 into apache:main Feb 19, 2026
14 checks passed
@tokoko tokoko deleted the jni-get-objects branch February 19, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments