feat(go/adbc/driver/bigquery): Add option to link failed jobs #3614
feat(go/adbc/driver/bigquery): Add option to link failed jobs #3614ajhlee-dbt wants to merge 1 commit intoapache:mainfrom
Conversation
lidavidm
left a comment
There was a problem hiding this comment.
Is there any reason to make this an option vs just always including it in the error?
Verbosity of the error message. |
|
Is it that much? I personally detest having to hunt for the "give me the real error" knob |
|
Could we just always put it into the ErrorDetails? That way the full error is still there but the user can decide if they want it in the output or not |
|
My one concern with ErrorDetails is then the vendor code can't be read, but (1) hopefully we fix that soon with an API revision (2) maybe BigQuery doesn't use that anyways? |
|
@lidavidm looking at the bigquery docs, it doesn't look like the error messages include a vendor code, so I don't think it's an issue to use the ErrorDetails etc. |
|
@felipecrv thoughts? |
Added an option to wrap query errors on Bigquery with a link to the failing query job. This is configurable via "adbc.bigquery.sql.query.link_failed_job".