fix(wolf-rbac): clear upstream identity headers when auth response omits userInfo#13696
Open
shreemaan-abhishek wants to merge 1 commit into
Open
Conversation
nic-6443
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
wolf-rbacplugin injectsX-UserId/X-Username/X-Nicknameupstream headers from the auth server'suserInfo, but only inside theif type(res.userInfo) == 'table'guard. When the access-check backend authorizes a request (HTTP 200) without returninguserInfo, that block is skipped and any client-suppliedX-UserId/X-Username/X-Nicknameheaders reach the upstream unchanged.This aligns
wolf-rbacwith the other auth plugins (forward-auth,opa,openid-connect,dingtalk-auth,feishu-auth), which already clear these client-supplied identity headers unconditionally before applying the auth response. The plugin now drops the three headers before theuserInfogate, so the happy path still overwrites them fromuserInfoand the no-userInfopath no longer forwards client values.Which issue(s) this PR fixes:
Fixes #
Checklist