feat(openid-connect): add stateless session revocation options#13651
Open
Hockenba wants to merge 6 commits into
Open
feat(openid-connect): add stateless session revocation options#13651Hockenba wants to merge 6 commits into
Hockenba wants to merge 6 commits into
Conversation
Hockenba
changed the title
Hockenba
marked this pull request as ready for review
July 2, 2026 17:42
dosubot
Bot
added
size:XL
Remove resty.session integration tests that manually injected revocation state; APISIX now passes redis.mode through to lua-resty-session unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
dosubot
Bot
added
size:L
Cover normal configs first, then variants and edge cases, with validation last.
dosubot
Bot
added
size:XL
3 tasks
Member
|
Hello @Hockenba,
Update: This PR depends on bungle/lua-resty-session#208 status https://the-asf.slack.com/archives/CUC5MN17A/p1783014722148709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
session.redis.mode(storage|revocation) andsession.revocation_fail_mode(open|closed) to the openid-connect plugin schema and documents them in the English plugin reference.Session options are passed through to
lua-resty-sessionunchanged; the library loads the Redis denylist whenstorageiscookieand Redis is configured for revocation. APISIX does not translate config to arevocation=trueflag.Adds
t/plugin/openid-connect-revocation.tfor schema validation and_build_session_optspassthrough (typical configs, variants, edge cases, and rejection of invalid or deprecated fields).Depends on bungle/lua-resty-session#208 for runtime revocation behavior.
Checklist
Test plan
prove t/plugin/openid-connect-revocation.trevocation_fail_mode=open), passthrough, redis session storageredis.mode, cookie-only sessionmode=storageon cookie, fail mode without redis,storage=redis+mode=revocationschema acceptancerevocation_fail_mode, invalidredis.mode, deprecatedsession.revocationrejectedprove t/plugin/openid-connect*.t(no regressions in existing openid-connect tests)session.redis.mode=revocationinvalidates the session via Redis denylist