Conversation
xvega
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
September 20, 2026 09:35
xvega
force-pushed
the
fix-cncf-async-client-reuse
branch
from
September 20, 2026 09:42
55a76bf to
e069fec
Compare
xvega
force-pushed
the
fix-cncf-async-client-reuse
branch
2 times, most recently
from
September 21, 2026 15:51
631c695 to
8de245a
Compare
Miretpl
requested changes
Sep 21, 2026
Miretpl
left a comment
Contributor
There was a problem hiding this comment.
I think that I approved this modification in the past, but after taking a bit more deeper look, I think that we have to do some modifications here to not make optimalization more important than operation stability.
xvega
force-pushed
the
fix-cncf-async-client-reuse
branch
from
September 22, 2026 13:13
8de245a to
71a1821
Compare
xvega
force-pushed
the
fix-cncf-async-client-reuse
branch
from
October 2, 2026 19:01
71a1821 to
d270ed2
Compare
update_params_for_auth is sync before kubernetes_asyncio 33, so await it only when it returns an awaitable.
xvega
force-pushed
the
fix-cncf-async-client-reuse
branch
from
October 4, 2026 18:51
8988227 to
470d848
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extracted the cncf.kubernetes changes from #71349 so they can be reviewed and merged independently.
Direct hook users must call await hook.close() when finished. Cached TLS material is retained until the client is recreated.
Was generative AI tooling used to co-author this PR?