-
Notifications
You must be signed in to change notification settings - Fork 17.7k
Add common.compat alias for BaseEventTrigger #72140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amoghrajesh
wants to merge
2
commits into
apache:main
Choose a base branch
from
astronomer:common-compat-base-event-trigger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
providers/common/compat/src/airflow/providers/common/compat/triggers.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| """Compatibility imports for core trigger base classes across Airflow 2 and Airflow 3.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| from airflow.providers.common.compat._compat_utils import create_module_getattr | ||
|
|
||
| if TYPE_CHECKING: | ||
| from airflow.triggers.base import BaseEventTrigger as BaseEventTrigger | ||
|
|
||
|
|
||
| # Airflow 3.0 added BaseEventTrigger to mark triggers usable as event-driven scheduling sources. | ||
| # Airflow 2.x has no such marker, so it falls back to BaseTrigger: subclasses still work as | ||
| # deferred triggers there, they just cannot drive an asset watcher. | ||
| _RENAME_MAP: dict[str, tuple[str, str, str]] = { | ||
| "BaseEventTrigger": ("airflow.triggers.base", "airflow.triggers.base", "BaseTrigger"), | ||
| } | ||
|
|
||
| __getattr__ = create_module_getattr(import_map={}, rename_map=_RENAME_MAP) | ||
|
|
||
| __all__ = sorted(_RENAME_MAP.keys()) | ||
36 changes: 36 additions & 0 deletions
36
providers/common/compat/tests/unit/common/compat/test_triggers.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import pytest | ||
|
|
||
| import airflow.triggers.base | ||
| from airflow.providers.common.compat import triggers | ||
|
|
||
|
|
||
| class TestBaseEventTrigger: | ||
| def test_falls_back_to_base_trigger_without_base_event_trigger(self, monkeypatch): | ||
| """On Airflow 2.x, where the class does not exist, the alias resolves to BaseTrigger.""" | ||
| # Already absent when the tests run against Airflow 2.x, which is the case being simulated. | ||
| monkeypatch.delattr(airflow.triggers.base, "BaseEventTrigger", raising=False) | ||
|
|
||
| assert triggers.BaseEventTrigger is airflow.triggers.base.BaseTrigger | ||
|
|
||
| def test_unknown_attribute_raises(self): | ||
| with pytest.raises(AttributeError, match="module has no attribute 'NotATrigger'"): | ||
| triggers.NotATrigger |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nit: Do we need to remove the
sortedcall here?