Skip to content

Allow Variable.get_variable_from_secrets to reuse session #72121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saitejabandaru-in wants to merge 1 commit into from
Closed

Allow Variable.get_variable_from_secrets to reuse session #72121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions airflow-core/src/airflow/models/variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ def check_for_write_conflict(key: str) -> None:
return None

@staticmethod
def get_variable_from_secrets(key: str, team_name: str | None = None) -> str | None:
def get_variable_from_secrets(key: str, team_name: str | None = None, *, session: Session | None = None) -> str | None:
"""
Get Airflow Variable by iterating over all Secret Backends.

Expand All @@ -480,8 +480,12 @@ def get_variable_from_secrets(key: str, team_name: str | None = None) -> str | N
# iterate over backends if not in cache (or expired)
for secrets_backend in ensure_secrets_loaded():
try:
kwargs = {"team_name": team_name, "key": key}
if type(secrets_backend).__name__ == "MetastoreBackend" and session is not None:
kwargs["session"] = session

var_val = call_secrets_backend_method(
secrets_backend.get_variable, team_name=team_name, key=key
secrets_backend.get_variable, **kwargs
)
if var_val is not None:
break
Expand Down
Loading