Add missing Druid Ingest connection type - #72104
Open
FrankYang0529 wants to merge 1 commit into
Open
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
potiuk
force-pushed
the
airflow-28790-druid-ingest-conn-type
branch
from
August 26, 2026 16:21
7a41d66 to
945b0b7
Compare
FrankYang0529
marked this pull request as ready for review
August 27, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DruidHookis on that list but it's not finished.DruidHookdidn't declareconn_type, so "Druid Ingest" was missing from the connection type dropdown.druid_ingest_defaultconnection usedconn_type="druid", and the hook usesconn_typeas the URL scheme, so it produceddruid://druid-overlord:8081/...andrequestsraisedInvalidSchema.How
conn_name_attr,default_conn_name,conn_typeandhook_nameonDruidHook, and registerdruid_ingestinprovider.yaml.get_connection_type()no longer returns the hook's ownconn_typeas a URL scheme, sodruid_ingestfalls back tohttp. Any otherconn_typestill passes through, so connections that set it tohttpskeep working.druid_ingest_defaultconnection withconn_type="druid_ingest"so it builds a usable URL.Verification
uv run --project providers/apache/druid pytest providers/apache/druid/tests/unit -xvsuv run --project airflow-core pytest airflow-core/tests/unit/utils/test_db.py -xvsWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.