Skip to content

Add missing Druid Ingest connection type - #72104

Open
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-28790-druid-ingest-conn-type
Open

Add missing Druid Ingest connection type#72104
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-28790-druid-ingest-conn-type

Conversation

@FrankYang0529

@FrankYang0529 FrankYang0529 commented Aug 26, 2026

Copy link
Copy Markdown
Member

Why

How

  • Declare conn_name_attr, default_conn_name, conn_type and hook_name on DruidHook, and register druid_ingest in provider.yaml.
  • get_connection_type() no longer returns the hook's own conn_type as a URL scheme, so druid_ingest falls back to http. Any other conn_type still passes through, so connections that set it to https keep working.
  • Create the default druid_ingest_default connection with conn_type="druid_ingest" so it builds a usable URL.

Verification

  • uv run --project providers/apache/druid pytest providers/apache/druid/tests/unit -xvs
  • uv run --project airflow-core pytest airflow-core/tests/unit/utils/test_db.py -xvs
Screenshot 2026-08-26 at 11 04 20 PM
Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>
@potiuk
potiuk force-pushed the airflow-28790-druid-ingest-conn-type branch from 7a41d66 to 945b0b7 Compare August 26, 2026 16:21
@FrankYang0529
FrankYang0529 marked this pull request as ready for review August 27, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant