Validate deferred trigger classpath resolves to a BaseTrigger subclass#69792
Open
hypnguyen1209 wants to merge 1 commit into
Open
Validate deferred trigger classpath resolves to a BaseTrigger subclass#69792hypnguyen1209 wants to merge 1 commit into
hypnguyen1209 wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the triggerer’s deferred-trigger loading path by validating that a deferred-task classpath resolves to a BaseTrigger subclass before caching/instantiation, preventing arbitrary importable callables from being invoked in the triggerer process.
Changes:
- Add a
BaseTrigger-subclass validation (and clearer docstring) inTriggerRunner.get_trigger_by_classpath. - Add a unit test covering both an allowed trigger class and a rejected non-trigger callable.
- Add a release-note newsfragment describing the security hardening (but the fragment filename needs correction).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| airflow-core/src/airflow/jobs/triggerer_job_runner.py | Validates imported objects are BaseTrigger subclasses before caching/instantiation. |
| airflow-core/tests/unit/jobs/test_triggerer_job.py | Adds regression test for accepting a real trigger and rejecting a non-trigger callable classpath. |
| airflow-core/newsfragments/99999.bugfix.rst | Adds release note entry for the hardening (currently named with a placeholder). |
The triggerer resolves a trigger from the ``classpath`` carried in the deferred-task Execution API payload via ``import_string(classpath)`` and then instantiates it with ``trigger_class(**kwargs)``. ``get_trigger_by_classpath`` did not check that the imported object is actually a ``BaseTrigger`` subclass, so any importable callable (e.g. ``subprocess.check_output``) could be loaded and invoked in the long-running triggerer process. Harden this by rejecting, before caching and before instantiation, any ``classpath`` that does not resolve to a ``type`` that is a ``BaseTrigger`` subclass. Legitimate triggers are unaffected (they are always ``BaseTrigger`` subclasses); an invalid classpath now fails the trigger cleanly instead of being instantiated. Adds a unit test covering both the accepted and rejected cases.
7794470 to
672b5f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The triggerer resolves a trigger from the
classpathcarried in the deferred-task Execution API payload viaimport_string(classpath)and then instantiates it withtrigger_class(**kwargs).get_trigger_by_classpathdid not check that the imported object is actually aBaseTriggersubclass, so any importable callable (e.g.subprocess.check_output) could be loaded and invoked in the long-running triggerer process.Harden this by rejecting, before caching and before instantiation, any
classpaththat does not resolve to atypethat is aBaseTriggersubclass. Legitimate triggers are unaffected (they are alwaysBaseTriggersubclasses); an invalid classpath now fails the trigger cleanly instead of being instantiated. Adds a unit test covering both the accepted and rejected cases.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.