Add notification UX for HITL actions#68346
Draft
parkhojeong wants to merge 8 commits into
Draft
Conversation
Surface pending HITL actions with review flows for quick response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a HITL Modal for quick action. It helps user can quickly reply pending HITL tasks.
Two types of UI are Modal or Drawer
Modal: show the pending HITL tasks with quick action.
/): when theRequired ActionsButton is clicked, show the Modal for the all tasks./dags/{dag_id}): replaceRequired Actionstab withRequired ActionsButton. When the Button is clicked, show the Modal including tasks for that Dag with filters for Pending(default) and All.dags/{dag_id}/runs/{dag_run_id}): replaceRequired Actionstab withRequired ActionsButton. When the Button is clicked, show the Modal including tasks for that Dag Run with filters for Pending(default) and All.Notes: Dag page, Dag Run page ending with
/required_actions: - show the Modal with pending filter by default for the backward compatibility.Drawer: show the action for pending HITL task.
/required_actions): when the row is clicked, show the Drawer