UI: Fix misleading Calendar Total Runs coloring behavior#67595
Draft
YeonShin wants to merge 2 commits into
Draft
UI: Fix misleading Calendar Total Runs coloring behavior#67595YeonShin wants to merge 2 commits into
YeonShin wants to merge 2 commits into
Conversation
e1fa137 to
3d41971
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Calendar tab
Total Runsview to render calendar cell colors based on state severity instead of simple run count aggregation, and adds missing tooltip colors.Why
As discussed in #66959, I identified a few misleading visual behaviors in the Calendar view.
1. Misleading Cell Rendering (
Total Runsmode)The calendar rendering logic did not differentiate between Actual states (
Success,Failed,Running). Instead, it relied on aggregated actual run counts to determine cell intensity and only checked whether pending states (Queued,Planned) existed to apply a mixed pending color.As a result, cell colors primarily reflected run volume rather than execution severity.
This caused misleading UI behavior where cells containing failed runs could still appear green, making failures less noticeable.
2. Missing Tooltip Colors
CalendarTooltip.tswas missing color definitions for thequeuedstate.As a result, queued runs could appear with fallback gray colors or visually blend with other states such as
Running, creating inconsistent and misleading UI feedback.Fix
In a monitoring tool like Airflow, severity is more important than frequency.
Even if there are 100 successful runs, a single failure should remain visible.
To address this, I updated the rendering logic in
calendarUtils.tsto prioritize colors based on execution severity.Updated Cell Color Priority
Priority order:
Rendering examples:
Successis intentionally hiddenPending State Handling (
Queued/Planned)Visuals (Before & After)
closes: #66959
Was generative AI tooling used to co-author this PR?
Generated-by: Gemini following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.