Skip to content

Fix internal server error on backfill API for SQLite#67587

Open
Jualhosting wants to merge 2 commits into
apache:mainfrom
Jualhosting:fix-sqlite-backfill
Open

Fix internal server error on backfill API for SQLite#67587
Jualhosting wants to merge 2 commits into
apache:mainfrom
Jualhosting:fix-sqlite-backfill

Conversation

@Jualhosting
Copy link
Copy Markdown

@Jualhosting Jualhosting commented May 27, 2026


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 27, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Copy Markdown
Contributor

@SameerMesiah97 SameerMesiah97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is reasonable and contained, but it is diffiicult to see how these lines resolve the internal server error. Could you expand more on the error you encountered and how your fix relates to it?

@Jualhosting
Copy link
Copy Markdown
Author

During backfills (e.g., when locking task instances), Airflow calls with_row_locks which applies SQLAlchemy's with_for_update(). Since SQLite does not natively support SELECT ... FOR UPDATE row-level locking, SQLAlchemy or the database driver throws an OperationalError / compilation error, causing a 500 Internal Server Error in the API. Since Airflow doesn’t support concurrent task execution with SQLite anyway, row-level locking isn't necessary. By adding a fast path to return the query untouched when dialect_name == "sqlite", we bypass the unsupported FOR UPDATE generation entirely, preventing the error while preserving the correct functional behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants