Fix registry backfill with per-provider versions and Docker extraction#65223
Open
kaxil wants to merge 2 commits intoapache:mainfrom
Open
Fix registry backfill with per-provider versions and Docker extraction#65223kaxil wants to merge 2 commits intoapache:mainfrom
kaxil wants to merge 2 commits intoapache:mainfrom
Conversation
potiuk
reviewed
Apr 14, 2026
|
|
||
| rebuild_or_pull_ci_image_if_needed(command_params=shell_params) | ||
|
|
||
| # Place isolated providers.json under dev/registry/ so it's visible inside the container |
Member
There was a problem hiding this comment.
Should be "files" not dev most likely.
potiuk
reviewed
Apr 14, 2026
potiuk
approved these changes
Apr 14, 2026
Member
potiuk
left a comment
There was a problem hiding this comment.
My comments are not blocking - but I have a feeling things can be quite simplified with leveraging uv
Chain both extraction scripts in a single uv run invocation to avoid creating two ephemeral environments per version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry backfill workflow had two problems preventing it from backfilling intermediate provider versions:
Flat version list applied to all providers: Input like
providers="amazon google" versions="9.24.0 21.0.0"tried all versions against all providers, failing because amazon doesn't have 21.0.0 and google doesn't have 9.24.0.Missing system dependencies: Extraction ran
uv run --withon a bare GitHub runner, which lacks C libraries (krb5-dev, libxml2-dev) needed by providers like amazon and google.Changes
Workflow (
registry-backfill.yml):providers+versionsinputs withprovider-versionsacceptingprovider/versionpairs (e.g.amazon/9.24.0 google/21.0.0 amazon/9.23.0)build-ci-imagejob andprepare_breeze_and_imagestep (same pattern asregistry-build.yml)Breeze command (
registry_commands.py):_backfill_docker()that runs extraction inside the Breeze CI container viapip install+execute_command_in_shell_backfill_uv()as--no-dockerfallback--no-dockerfor faster iterationExample usage
This creates parallel jobs: one for amazon (9.24.0), one for google (21.0.0), one for celery (3.17.2). Multiple versions per provider are grouped into a single job.