Skip to content

fix(cli): change is_alive default to None in jobs list#65065

Open
rjgoyln wants to merge 1 commit intoapache:mainfrom
rjgoyln:fix/jobs-list-default-is-alive-filter
Open

fix(cli): change is_alive default to None in jobs list#65065
rjgoyln wants to merge 1 commit intoapache:mainfrom
rjgoyln:fix/jobs-list-default-is-alive-filter

Conversation

@rjgoyln
Copy link
Copy Markdown
Contributor

@rjgoyln rjgoyln commented Apr 11, 2026

Summary

This PR fixes a logic error where jobs list unintentionally filtered out active jobs because the is_alive parameter defaulted to False. By implementing three-state logic (True/False/None) and setting the default to None, the command now correctly returns all jobs unless an explicit filter is applied.

Changes

  • CLI Configuration: Updated the argument generation logic to set arg_default=None for boolean parameters to distinguish between "not specified" and "explicitly false."
  • Operations Layer: Refactored JobsOperations.list to use a dynamic parameter mapping, ensuring is_alive is only sent to the API if explicitly set by the user.
  • Type Safety: Improved type handling to support bool | None (Optional[bool]) and fixed Mypy type mismatch errors in the parameter dictionary.
  • Testing: Added unit tests to verify that CommandFactory correctly generates BooleanOptionalAction with a None default for optional boolean fields.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant