Skip to content

Add workers.celery.logGroomerSidecar section#65033

Merged
jscheffl merged 3 commits intoapache:mainfrom
Miretpl:add-workers-celery-log-groomer
Apr 12, 2026
Merged

Add workers.celery.logGroomerSidecar section#65033
jscheffl merged 3 commits intoapache:mainfrom
Miretpl:add-workers-celery-log-groomer

Conversation

@Miretpl
Copy link
Copy Markdown
Contributor

@Miretpl Miretpl commented Apr 10, 2026

related: #28880

This PR introduces a new workers.celery.logGroomerSidecar section and deprecates the old workers.logGroomerSidecar section (as it was only applicable to Celery workers).


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Miretpl Miretpl force-pushed the add-workers-celery-log-groomer branch from 6534a4b to f6d39c3 Compare April 12, 2026 11:11
@Miretpl Miretpl marked this pull request as ready for review April 12, 2026 11:14
@jscheffl jscheffl added the backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch label Apr 12, 2026
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I see another candidate for Kustomize :-D
(On the other hand log cleanup is quite common but I am wondering why we need so many parameters for this...)

@Miretpl
Copy link
Copy Markdown
Contributor Author

Miretpl commented Apr 12, 2026

I would say that probably most Kubernetes setups use it (so not sure if Kustomize or not - no strong opinion for now), but for sure, we do not need all of these parameters :D

@jscheffl jscheffl merged commit 556380f into apache:main Apr 12, 2026
192 of 196 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 12, 2026
* Add workers.celery.logGroomerSidecar section

* Add newsfragment

* Fix spellcheck & tests
(cherry picked from commit 556380f)

Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

Backport successfully created: chart/v1-2x-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
chart/v1-2x-test PR Link

jscheffl pushed a commit that referenced this pull request Apr 12, 2026
…) (#65083)

* Add workers.celery.logGroomerSidecar section

* Add newsfragment

* Fix spellcheck & tests
(cherry picked from commit 556380f)

Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
@Miretpl Miretpl deleted the add-workers-celery-log-groomer branch April 12, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants