Skip to content

Check execution API datamodel changes have corresponding version updates#62755

Merged
jason810496 merged 9 commits intoapache:mainfrom
jason810496:ci/add-check-execution-api-versions-prek-check
Mar 12, 2026
Merged

Check execution API datamodel changes have corresponding version updates#62755
jason810496 merged 9 commits intoapache:mainfrom
jason810496:ci/add-check-execution-api-versions-prek-check

Conversation

@jason810496
Copy link
Copy Markdown
Member

@jason810496 jason810496 commented Mar 3, 2026

Why

There're quite a lot of PRs doesn't add corresponding cadwyn version files in the past review.

For examples:

To prevent further regression, it would be better to add a prek hook to enforce us to add the cadwyn version files, at least at file level.

What

There're two cases for the validation

  1. In CI: Get changed files in a CI environment by comparing against the target branch
  2. Local developer environment: Get staged files in a local (non-CI) environment.

Verfication

  1. In real GitHub Action CI (with commit 3e28f36, CI run: https://github.com/apache/airflow/actions/runs/22708132039/job/65840653068)
Screenshot 2026-03-06 at 2 54 11 PM
  1. git commit locally
Screenshot 2026-03-05 at 3 57 07 PM
Was generative AI tooling used to co-author this PR?

If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to [X] followed by the name of the tool, uncomment the "Generated-by".

  • Yes (please specify the tool below)

Generated-by: GitHub Coding Agent with Ops 4.6

Copy link
Copy Markdown
Member Author

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another regression example like: #62259 (comment)

Copy link
Copy Markdown
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@amoghrajesh
Copy link
Copy Markdown
Contributor

LGTM still.

Copilot AI and others added 9 commits March 12, 2026 11:22
@jason810496 jason810496 force-pushed the ci/add-check-execution-api-versions-prek-check branch from b6f12d9 to bb6fce7 Compare March 12, 2026 03:22
Copy link
Copy Markdown
Member Author

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskSDK will always be released from main and all the failing test cases are not related, so I remove backport-to-v3-1-test before merging.

@jason810496 jason810496 merged commit 9d027a4 into apache:main Mar 12, 2026
65 of 69 checks passed
PascalEgn pushed a commit to PascalEgn/airflow that referenced this pull request Mar 12, 2026
…tes (apache#62755)

* Initial plan

* Add pre-commit hook to check execution API datamodel changes have version updates

Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>

* Address code review: add warning on fetch failure

Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>

* Align common prek script usage

* Fix CI error

* Test CI verfication: Should raise error on CI

* Revert "Test CI verfication: Should raise error on CI"

This reverts commit 3e28f36.

* Exclude __init__.py from execution API datamodel version check

Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>

* Fix ruff formatting

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>
Pyasma pushed a commit to Pyasma/airflow that referenced this pull request Mar 13, 2026
…tes (apache#62755)

* Initial plan

* Add pre-commit hook to check execution API datamodel changes have version updates

Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>

* Address code review: add warning on fetch failure

Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>

* Align common prek script usage

* Fix CI error

* Test CI verfication: Should raise error on CI

* Revert "Test CI verfication: Should raise error on CI"

This reverts commit 3e28f36.

* Exclude __init__.py from execution API datamodel version check

Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>

* Fix ruff formatting

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants