Check execution API datamodel changes have corresponding version updates#62755
Merged
jason810496 merged 9 commits intoapache:mainfrom Mar 12, 2026
Merged
Conversation
jason810496
commented
Mar 6, 2026
Member
Author
jason810496
left a comment
There was a problem hiding this comment.
Another regression example like: #62259 (comment)
Contributor
|
LGTM still. |
…sion updates Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>
Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>
This reverts commit 3e28f36.
Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>
b6f12d9 to
bb6fce7
Compare
jason810496
commented
Mar 12, 2026
PascalEgn
pushed a commit
to PascalEgn/airflow
that referenced
this pull request
Mar 12, 2026
…tes (apache#62755) * Initial plan * Add pre-commit hook to check execution API datamodel changes have version updates Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> * Address code review: add warning on fetch failure Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> * Align common prek script usage * Fix CI error * Test CI verfication: Should raise error on CI * Revert "Test CI verfication: Should raise error on CI" This reverts commit 3e28f36. * Exclude __init__.py from execution API datamodel version check Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com> * Fix ruff formatting --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>
Pyasma
pushed a commit
to Pyasma/airflow
that referenced
this pull request
Mar 13, 2026
…tes (apache#62755) * Initial plan * Add pre-commit hook to check execution API datamodel changes have version updates Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> * Address code review: add warning on fetch failure Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> * Align common prek script usage * Fix CI error * Test CI verfication: Should raise error on CI * Revert "Test CI verfication: Should raise error on CI" This reverts commit 3e28f36. * Exclude __init__.py from execution API datamodel version check Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com> * Fix ruff formatting --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
There're quite a lot of PRs doesn't add corresponding cadwyn version files in the past review.
For examples:
To prevent further regression, it would be better to add a prek hook to enforce us to add the cadwyn version files, at least at file level.
What
There're two cases for the validation
Verfication
git commitlocallyWas generative AI tooling used to co-author this PR?
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to
[X]followed by the name of the tool, uncomment the "Generated-by".Generated-by: GitHub Coding Agent with Ops 4.6