Fix: DecreasingPriorityStrategy example by initializing try_number before weight evaluation#62148
Open
aeroyorch wants to merge 1 commit intoapache:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The documented
DecreasingPriorityStrategycan fail becauseget_weight()may run whileTaskInstanceis still partially initialized, soti.try_numberis not ready. This PR applies a small fix by initializingtry_numberbeforerefresh_from_task()and adds a regression test case forDecreasingPriorityStrategy.Notes
This is a minimal fix. As a follow-up, it would be worth exploring whether priority strategies could be evaluated with richer context (including
DagRun/logical_date) and outside early lifecycle initialization. For example, this could enable strategies that decrease priority for older logical dates.Was generative AI tooling used to co-author this PR?