Refactor imports from 'airflow-core' out of 'shared/stats'#62127
Open
xBis7 wants to merge 5 commits intoapache:mainfrom
Open
Refactor imports from 'airflow-core' out of 'shared/stats'#62127xBis7 wants to merge 5 commits intoapache:mainfrom
xBis7 wants to merge 5 commits intoapache:mainfrom
Conversation
xBis7
requested review from
XD-DENG,
amoghrajesh,
ashb,
dheerajturaga,
dstandish,
ephraimbuddy,
hussein-awala,
jedcunningham,
kaxil,
o-nikolas,
pierrejeambrun and
potiuk
as code owners
boring-cyborg
bot
added
area:DAG-processing
area:Executors-core
Contributor
Author
|
@amoghrajesh @potiuk Can you take a look? |
amoghrajesh
reviewed
Feb 19, 2026
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
General direction looks good, thanks @xBis7!
Some comments and we are good.
xBis7
force-pushed
the
refactor-core-imports-in-stats
branch
from
f0c05d6 to
99c1e3b
Compare
amoghrajesh
approved these changes
Feb 19, 2026
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM +1
@potiuk WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch refactors the
Stats.initialize()method so that it won't import any packages fromairflow-core.Instead of that method making calculations and then initializing the correct factory object, it will accept the factory as a parameter.
The initialization logic will be moved under a utils file in
airflow-coreand a duplicate file intask-sdk. This is the best approach forward based on offline discussions.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.