Skip to content

Fix qualname() handling for functools.partial with exclude_module#62124

Closed
AhmedAli58 wants to merge 1 commit intoapache:mainfrom
AhmedAli58:codex/fix-qualname-partial
Closed

Fix qualname() handling for functools.partial with exclude_module#62124
AhmedAli58 wants to merge 1 commit intoapache:mainfrom
AhmedAli58:codex/fix-qualname-partial

Conversation

@AhmedAli58
Copy link
Contributor

What

Fix qualname(..., exclude_module=True) so functools.partial returns the wrapped callable's qualified name instead of partial.\n\n## Why\nThe shared module loading tests currently fail because partial callables can resolve to the type name (partial) instead of the wrapped function's qualname.\n\n## How\n- Add an early functools.partial guard in qualname() before module/name checks\n- Reuse existing wrapped callable resolution path\n\n## Verification\nPYTHONPATH=shared/module_loading/src python3 -m pytest -q shared/module_loading/tests\n- 23 passed

@potiuk
Copy link
Member

potiuk commented Feb 19, 2026

The description is very cryptic. Can you explain what you want to achieve here in a way that can be understood ? Seems that description is generated and badly formatted and it's upt to the author to follow generated guidelines and make PR description useful

Let me close the one - you can always open a better version of this with actual description of what you want to do and what problem it solves.

@potiuk potiuk closed this Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments