Fix qualname() handling for functools.partial with exclude_module#62124
Closed
AhmedAli58 wants to merge 1 commit intoapache:mainfrom
Closed
Fix qualname() handling for functools.partial with exclude_module#62124AhmedAli58 wants to merge 1 commit intoapache:mainfrom
AhmedAli58 wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
The description is very cryptic. Can you explain what you want to achieve here in a way that can be understood ? Seems that description is generated and badly formatted and it's upt to the author to follow generated guidelines and make PR description useful Let me close the one - you can always open a better version of this with actual description of what you want to do and what problem it solves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
qualname(..., exclude_module=True)sofunctools.partialreturns the wrapped callable's qualified name instead ofpartial.\n\n## Why\nThe shared module loading tests currently fail because partial callables can resolve to the type name (partial) instead of the wrapped function's qualname.\n\n## How\n- Add an earlyfunctools.partialguard inqualname()before module/name checks\n- Reuse existing wrapped callable resolution path\n\n## Verification\nPYTHONPATH=shared/module_loading/src python3 -m pytest -q shared/module_loading/tests\n- 23 passed