Skip to content

Fix UTC guard in from_timestamp to skip redundant timezone conversion#62122

Open
AhmedAli58 wants to merge 1 commit intoapache:mainfrom
AhmedAli58:codex/fix-from-timestamp-utc-guard
Open

Fix UTC guard in from_timestamp to skip redundant timezone conversion#62122
AhmedAli58 wants to merge 1 commit intoapache:mainfrom
AhmedAli58:codex/fix-from-timestamp-utc-guard

Conversation

@AhmedAli58
Copy link
Contributor

What

Fix from_timestamp() UTC guard condition so UTC inputs do not perform an unnecessary in_timezone() call.\n\n## Why\nThe previous condition used or, which is always true for this check and forced conversion even when tz was already UTC.\n\n## How\n- Change if tz != utc or tz != "UTC" to if tz != utc and tz != "UTC"\n- Add regression tests to ensure UTC object and "UTC" string skip timezone conversion\n\n## Verification\nPYTHONPATH=shared/timezones/src python3 -m pytest -q shared/timezones/tests\n- 32 passed

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 18, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments