Fix UTC guard in from_timestamp to skip redundant timezone conversion#62122
Open
AhmedAli58 wants to merge 1 commit intoapache:mainfrom
Open
Fix UTC guard in from_timestamp to skip redundant timezone conversion#62122AhmedAli58 wants to merge 1 commit intoapache:mainfrom
AhmedAli58 wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
from_timestamp()UTC guard condition so UTC inputs do not perform an unnecessaryin_timezone()call.\n\n## Why\nThe previous condition usedor, which is always true for this check and forced conversion even whentzwas already UTC.\n\n## How\n- Changeif tz != utc or tz != "UTC"toif tz != utc and tz != "UTC"\n- Add regression tests to ensure UTC object and"UTC"string skip timezone conversion\n\n## Verification\nPYTHONPATH=shared/timezones/src python3 -m pytest -q shared/timezones/tests\n- 32 passed