Skip to content

fix triggerer logger's file descriptor closed when it removed#62103

Open
wjddn279 wants to merge 2 commits intoapache:mainfrom
wjddn279:fix-triggerer-logging-file-not-closed
Open

fix triggerer logger's file descriptor closed when it removed#62103
wjddn279 wants to merge 2 commits intoapache:mainfrom
wjddn279:fix-triggerer-logging-file-not-closed

Conversation

@wjddn279
Copy link
Contributor

@wjddn279 wjddn279 commented Feb 18, 2026

closed: #61916

An issue was reported where file descriptors were not being properly closed when the logger was destroyed in the existing triggerer.

As shown below, the number of open file descriptors was continuously increasing before this fix. After applying the logic in this PR, file descriptors are now properly closed and the count decreases as expected.

Additionally, we confirmed through added logging that the logger is properly garbage collected after upload_to_remote is called, triggering the destructor as expected.

image

AS-IS (3.1.7)

image image

TO-BE (patched)

image
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@eladkal
Copy link
Contributor

eladkal commented Feb 18, 2026

Can you add a test to avoid regression?

@eladkal eladkal added this to the Airflow 3.1.8 milestone Feb 18, 2026
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Feb 18, 2026
@wjddn279
Copy link
Contributor Author

sure. I'll add it

@wjddn279
Copy link
Contributor Author

@eladkal Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Triggerer type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer: too many open files

2 participants

Comments