fix triggerer logger's file descriptor closed when it removed#62103
Open
wjddn279 wants to merge 2 commits intoapache:mainfrom
Open
fix triggerer logger's file descriptor closed when it removed#62103wjddn279 wants to merge 2 commits intoapache:mainfrom
wjddn279 wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
Can you add a test to avoid regression? |
Contributor
Author
|
sure. I'll add it |
Contributor
Author
|
@eladkal Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed: #61916
An issue was reported where file descriptors were not being properly closed when the logger was destroyed in the existing triggerer.
As shown below, the number of open file descriptors was continuously increasing before this fix. After applying the logic in this PR, file descriptors are now properly closed and the count decreases as expected.
Additionally, we confirmed through added logging that the logger is properly garbage collected after
upload_to_remoteis called, triggering the destructor as expected.AS-IS (3.1.7)
TO-BE (patched)
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.