fix: allow reduce and list comprehensions in LIMIT and SKIP - #2557
Open
1fanwang wants to merge 1 commit into
Open
fix: allow reduce and list comprehensions in LIMIT and SKIP#25571fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIMITandSKIPrejectreduce()and list comprehensions withERROR: 0A000: unsupported SubLink. These expressions do not contain a user-written subquery, but AGE represents their iteration internally as a sublink.The parser now permits sublinks while transforming
LIMITandOFFSETexpressions, matching PostgreSQL's handling of those contexts. On current master, all four cases from the issue fail. On this branch, each returns1.Closes #2518.
Testing
Regression tests
PostgreSQL 18.6 query results