Repository navigation
Conversation
…forwarded message VirtualConsumerDemandTest.testToTopicWithDurable and testToTopic occasionally fail on CI at bridgeConsumer.receive(5000) (see apache#2238) and cannot be reproduced locally. On a receive timeout, dump the include.* destinations, their subscriptions and statistics on both brokers, plus the bridge demand subscriptions, so the next flaky failure shows where the message was lost. Diagnostics only, no change to the test behaviour. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2238 (flaky test cleanup,
VirtualConsumerDemandTest.testToTopicWithDurable:1358).VirtualConsumerDemandTest.testToTopicWithDurable(andtestToTopic, seen failing onmainat line 1281) occasionally fails on CI atbridgeConsumer.receive(5000): the message never reaches the remote durable subscriber. I could not reproduce it locally (640 runs under CPU load on JDK 21), and ruled out two theories:waitForConsumerCountis not satisfied prematurely: the local consumer count is 0 until the durable's demand propagates.subscriptionMapByLocalIdbefore creating the local consumer, so it cannot drop the first message.This PR is diagnostics only, not a fix. On a receive timeout it now fails with a dump of:
include.*destinations on both brokers, with their statistics and subscriptionsso the next CI flake shows where the message was lost (local topic, bridge, or remote composite/durable). Test behaviour is otherwise unchanged. The helper replaces the 8
assertNotNull(bridgeConsumer.receive(5000))calls in this class.Verified locally: all 16
testTo*runs pass, and a forced timeout prints the expected dump.🤖 Generated with Claude Code