Open
Conversation
…pache#1718) ActiveMQ reports JMS version as 1.1 (JMS 1.1 era). Since the project now uses jakarta.jms (Jakarta Messaging 3.1), the metadata must match. - getJMSVersion(): "1.1" → "3.1" - getJMSMajorVersion(): 1 → 3
…pache#1722) (apache#1724) (apache#1719) Several methods threw wrong exception types, causing TCK failures: - MessageProducer.send() with null destination on an unbound producer threw UnsupportedOperationException instead of InvalidDestinationException - JMSProducer.send() with null message threw NPE instead of MessageFormatRuntimeException - checkClientIDWasManuallySpecified() threw JMSException instead of jakarta.jms.IllegalStateException for durable subscribers without a client ID
…es (apache#1720) getPropertyNames() only included JMSXDeliveryCount when redeliveryCounter != 0. Since JMSXDeliveryCount = redeliveryCounter + 1, it is always >= 1 on a received message and should always be enumerated. The TCK sets 17 custom properties and expects getPropertyNames() to return 18 (17 + JMSXDeliveryCount).
…shared consumer methods (apache#1719) The shared consumer methods (createSharedConsumer, createSharedDurableConsumer) threw UnsupportedOperationException immediately without validating inputs. Per the JMS spec, parameter validation must happen first: - Session: null topic now throws InvalidDestinationException, invalid selector now throws InvalidSelectorException - JMSContext: null topic now throws InvalidDestinationRuntimeException This fixes the TCK invalidDestinationExceptionTests and invalidSelectorExceptionTopicTests for Session, and the corresponding JMSContext tests.
…d enforce callback restrictions
…t destination parameter calling send(destination, message) on fixed-destination producers — a JMS spec violation that the old code silently allowed
fix send calls to remove the destination
jeanouii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.