Skip to content

AMQP: added transport factory unit tests for mutex stripping and monitor wiring.#1725

Open
asaxena14 wants to merge 5 commits intoapache:mainfrom
asaxena14:AMQP-transport-factoryTcs
Open

AMQP: added transport factory unit tests for mutex stripping and monitor wiring.#1725
asaxena14 wants to merge 5 commits intoapache:mainfrom
asaxena14:AMQP-transport-factoryTcs

Conversation

@asaxena14
Copy link

This PR adds focused unit coverage for AMQP transport factories to validate configuration behaviour.

Added test:
AmqpTransportFactoryConfigurationTest.java

Factories covered:

  • AmqpTransportFactory
  • AmqpSslTransportFactory
  • AmqpNioTransportFactory
  • AmqpNioSslTransportFactory

What is verified:

  • serverConfigure(...) strips broker-side MutexTransport
  • compositeConfigure(...) applies AMQP and wireFormat.* properties (transformer, producerCredit, maxFrameSize, connectAttemptTimeout)
  • inactivity monitor wiring is correct (AmqpInactivityMonitor is present in the transport chain and the same monitor instance is set on AmqpTransportFilter)

@asaxena14 asaxena14 marked this pull request as ready for review February 25, 2026 10:55
@jbonofre jbonofre self-requested a review February 25, 2026 10:59
return new TcpTransport(
wireFormat,
SocketFactory.getDefault(),
new URI("tcp://localhost:61616"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a dynamic port here to avoid tests conflicts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code to use dynamic ports.

@asaxena14
Copy link
Author

CI Quick is blocked as workflow is awaiting approval from a maintainer. Can someone Please provide an approval for this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants